Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tinymembench: init at 0.4 #287542

Merged
merged 1 commit into from
Mar 24, 2024
Merged

tinymembench: init at 0.4 #287542

merged 1 commit into from
Mar 24, 2024

Conversation

lorenz
Copy link
Contributor

@lorenz lorenz commented Feb 9, 2024

Description of changes

Adds tinymembench, a simple benchmark for memory throughput and latency.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 馃憤 reaction to pull requests you find important.

raspher
raspher suggested changes Feb 10, 2024
View reviewed changes
pkgs/by-name/ti/tinymembench/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/ti/tinymembench/package.nix Show resolved Hide resolved
@raspher
Copy link
Member

raspher commented Feb 11, 2024

@lorenz please rebase and squash your commits to init commit

@raspher
Copy link
Member

raspher commented Feb 11, 2024

Result of nixpkgs-review pr 287542 run on x86_64-linux 1

1 package built:
  • tinymembench

@lorenz
tinymembench: init at 0.4
d6ea568 
Adds tinymembench, a simple benchmark for memory throughput and latency.
@lorenz
Copy link
Contributor Author

lorenz commented Feb 11, 2024

Done

@raspher
Copy link
Member

raspher commented Feb 11, 2024

Reviewed points
  • package path fits guidelines
  • package name fits guidelines
  • package version fits guidelines
  • package builds on x86_64-linux
  • executables tested on x86_64-linux
  • meta.description is set and fits guidelines
  • meta.license fits upstream license
  • meta.platforms is set
  • meta.maintainers is set
  • build time only dependencies are declared in nativeBuildInputs
  • source is fetched using the appropriate function
  • the list of phases is not overridden
  • when a phase (like installPhase) is overridden it starts with runHook preInstall and ends with runHook postInstall.
  • patches have a comment describing either the upstream URL or a reason why the patch wasn't upstreamed
  • patches that are remotely available are fetched rather than vendored
Possible improvements
Comments

I'll wait for ofborg results before approving

@raspher raspher self-requested a review February 11, 2024 17:00
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/1518

@SuperSandro2000 SuperSandro2000 merged commit 332a28b into NixOS:master Mar 24, 2024
24 checks passed
@lorenz lorenz deleted the add-tinymembench branch March 29, 2024 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raspher raspher raspher approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer 12.approvals: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@lorenz @raspher @nixos-discourse @delroth @SuperSandro2000